Skip to content

fix: loop over forward slashes for relative dir, replace after urlencode#64

Merged
williamdes merged 1 commit intocode-lts:mainfrom
tiller1010:fix-slashes-in-branch-name
Feb 6, 2026
Merged

fix: loop over forward slashes for relative dir, replace after urlencode#64
williamdes merged 1 commit intocode-lts:mainfrom
tiller1010:fix-slashes-in-branch-name

Conversation

@tiller1010
Copy link
Contributor

@tiller1010 tiller1010 commented Jan 10, 2024

Fixes #63

  • Loops over forward slashes for "../" relative path.
  • Replaces URL-encoded forward slashes with the original slash.

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice, I will check the code base to see if this is the right solution or if other places could be broken

@codecov
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.99%. Comparing base (78ee960) to head (120ef45).
⚠️ Report is 132 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #64   +/-   ##
=========================================
  Coverage     63.99%   63.99%           
  Complexity     1252     1252           
=========================================
  Files            53       53           
  Lines          3611     3611           
=========================================
  Hits           2311     2311           
  Misses         1300     1300           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@williamdes
Copy link
Member

Update: I am a bit unsatisfied about the current code, maybe I will refactor it a bit before merging this
We should not have to split the path and re build it, it feels wrong

@williamdes williamdes changed the base branch from v5.5.x to main February 6, 2026 14:03
@williamdes williamdes self-assigned this Feb 6, 2026
@williamdes williamdes added this to the v5.7.0 milestone Feb 6, 2026
@williamdes williamdes merged commit f4bb5bc into code-lts:main Feb 6, 2026
@williamdes
Copy link
Member

Merged as f4bb5bc
Can you please test it on your end ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Branches with forward slashes in the name are not supported

3 participants