[pull] latest from ag-grid:latest #558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wip * wip * account for multiple conditions in filter toolpanel and column filters * fix selector
…es (#12819) * Extract sort logic into helper function for reusability - Extracted sort logic from multiple components into _getDisplaySortForColumn helper function - Simplified sort condition checks in sortIndicatorComp.ts and columnMenuFactory.ts - Added missing import for _getDisplaySortForColumn in main-internal.ts - Removed redundant code duplication across files - Improved maintainability and code consistency * Extract sort logic into helper function for reusability - Extracted sort logic from multiple components into _getDisplaySortForColumn helper function - Simplified sort condition checks in sortIndicatorComp.ts and columnMenuFactory.ts - Added missing import for _getDisplaySortForColumn in main-internal.ts - Removed redundant code duplication across files - Improved maintainability and code consistency * sonar * Add support for preset date filter types in simple filter - Added preset date filter types to `presetDateFilterModelTypes` array - Included preset date types in `zeroInputTypes` array for proper input handling - Updated `ISimpleFilterModelType` union type to include all date filter options - Maintained consistency with existing filter type definitions * Add support for named relative date ranges in date filters - Added `presetDateFilterTypeRelativeFromToMap` to map named relative date ranges to from/to date ranges - Implemented date range calculations for various relative time periods including today, yesterday, tomorrow, weekly, monthly, quarterly, yearly, and custom durations - Added support for additional date filter types: last7Days, last30Days, last90Days, last6Months, last12Months, last24Months - Updated `ISimpleFilterModelPresetType` type to include all new date filter options - Modified `zeroInputTypes` to include all date filter types for proper input handling - Added locale text for new date filter options - Improved date range calculation consistency across different time periods - Enhanced filter functionality with additional named relative date ranges feat #AG-14571 * Fix end of quarter calculation in date filter utils - Updated `setEndOfQuarter` to set month to 2, 5, 8, 11 instead of 3, 6, 9, 12 to correctly represent end of quarter - Ensured end of quarter calculation aligns with standard calendar quarters - Maintained consistency with date range calculations for relative date filters feat #AG-14571 * Update relative date filter calculations to use `today` preset - Replaced manual date calculations for last6Months, last12Months, and last24Months with `presetDateFilterTypeRelativeFromToMap.today` for consistency - Ensured all relative date ranges use the same date handling logic - Maintained backward compatibility while improving code maintainability - Simplified date range logic by leveraging existing preset logic feat #AG-14571 * remove comment * add run configs * Add built-in named and relative date ranges to date filter documentation * Refactor date filter handling to use unified date range logic - Removed deprecated manual date calculations for relative date ranges in favor of `presetDateFilterTypeRelativeFromToMap` - Centralized date range logic by leveraging existing preset mapping for consistency - Updated `DateFilterHandler` to use `beanCreationTime` for date calculations - Simplified `evaluateNonNullValue` method by reusing existing preset logic - Maintained backward compatibility while improving code maintainability - Ensured all relative date ranges use the same date handling approach feat #AG-14571 * - Consolidate date range functions into a single mapping object - Update date filter handling to use new mapping for relative ranges - Improve documentation for built-in date filter options - Remove unused date utility functions for cleaner codebase Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * human readable table Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * Craft an example Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * non-strict from date Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * - Consolidate date range functions into a single mapping object - Update date filter handling to use new mapping for relative ranges - Improve documentation for built-in date filter options - Remove unused date utility functions for cleaner codebase Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * remove comment, it's incorrect Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * lint Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * use utc in tests Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * Update date filter documentation to include built-in date ranges with example usage * Update date filter logic to use current time instead of bean creation time. * Update date filter to use consistent date handling by passing new Date() for both from and to calculations. * Shuffle around docs --------- Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> Co-authored-by: Stephen Cooper <scooperdev@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )