[pull] latest from ag-grid:latest #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* DASH-11 Auto grid bump and publish trigger * DASH-11 Auto grid bump and publish trigger * DASH-11 Auto grid bump and publish trigger * Add support for `bigint` data type in DataTypeService and related types. Introduce `bigint` as a supported base data type with appropriate parser, formatter, and matcher. Update type definitions to include `BigIntDataTypeDefinition` and extend `DataTypeDefinition` to include `bigint`. * Add support for `bigint` data type in filters - Add `bigint` filter type to various filter interfaces and type definitions - Update filter type enums to include `bigint` in text, number, date, and set filters - Add `BigIntFilter` and related components to filter module - Update floating filters to support `bigint` type - Add `agBigIntColumnFilter` and `agBigIntColumnFloatingFilter` to column filter options - Update validation rules and module definitions to include `BigIntFilterModule` - Add `bigint` to filter locale text - Update filter model type unions to include `BigIntFilterModel` * Add BigInt filter model formatter and utils - Add BigIntFilterModelFormatter class to handle formatting of bigint filter models - Implement helper functions for allowed char pattern and value processing in BigInt filter - Update floating filter to support bigint parsing and validation - Add type definitions for BigIntFilterModel and related parameters - Introduce bigint parser and formatter functionality in filter configuration * Add support for `bigint` data type in advanced filter - Add `bigint` to `modelValue` type in `ColFilterExpressionParser` and update validation for `bigint` type - Update `getModelValue` to return `bigint` when applicable - Add `bigint` to `operandValueGetters` with parsing logic for valid bigint values - Update `doesOperandNeedQuotes` to include `bigint` in non-quoted types - Add `BigIntAdvancedFilterModel` interface and extend `AdvancedFilterModel` union type - Update `buildBigIntFilterSchema` in AI feature schema to include bigint filter options - Update `processBigIntFilterValue` to use `getValue()` directly - Update `filterOperandGetters` to include `bigint` type - Update `operandModelValueGetters` to handle `bigint` parsing - Add `bigint` to `FilterExpressionService` for proper operand handling - Add `ScalarFilterExpressionOperators<bigint>` for bigint filter operations * Add support for `bigint` data type in DataTypeService and related components - Add `bigint` to `DataTypeService` with `cellEditor`, `comparator`, and `absoluteComparator` configurations - Introduce `bigintComparator` and `bigintAbsoluteComparator` functions for sorting `bigint` values - Add `toBigIntOrNull` and `toAbsoluteBigInt` utilities for safe `bigint` conversion - Update `filterDataTypeUtils` to use `toBigIntOrNull` for `bigint` comparisons - Add `bigint` to `AgInputTextField` in `inputPillComp` for advanced filter input - Update `conditionPillWrapperComp` to handle `bigint` operand parsing - Add `bigint` to `ScalarFilterExpressionOperators` for advanced filter operations - Update `modelValue` type in `ColFilterExpressionParser` to include `bigint` - Update `getModelValue` to return `bigint` when applicable - Add `bigint` to `operandValueGetters` with parsing logic - Update `doesOperandNeedQuotes` to include `bigint` in non-quoted types - Add `BigIntFilterModel` interface and extend `AdvancedFilterModel` union type - Update `filterExpressionOperators` to include `bigint` type - Add `BigIntFilterModule` to example and documentation - Update documentation to include `bigint` data type with details on formatting and sorting - Add `bigint` to `ColDef` types and `DataTypeDefinition` in `ag-grid-community` * Add focused cell state serialization and improve bigint filter state handling - Added focused cell state serialization in state service to persist focus across state saves - Enhanced bigint filter state handling with proper serialization and rehydration in grid state tests - Increased test timeout to ensure reliable execution of state serialization and restoration tests Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * Fix mixed number/bigint type handling in aggregation functions Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * Use bigint valueFormatter for group totals in groupCellRenderer - Added test to verify bigint valueFormatter is applied to group totals in groupCellRenderer - Updated dataTypeService to handle bigint values in aggregation and formatting - Enhanced filter state handling with proper bigint serialization in stateService - Improved test reliability by increasing timeout duration for state serialization tests Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * Apply consistent access modifiers to bigint-related interfaces and update group total cell selector - Made `BigIntDataTypeDefinition` and `BigIntAdvancedFilterModel` interfaces private to improve encapsulation - Updated test to use `.ag-row-footer` selector for group total value cell instead of `.ag-row-total` - Increased timeout in grid state test to ensure reliable execution of state serialization scenarios Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * lint Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * Update documentation and module size metrics for BigInt support - Updated Excel export reference link in cell data types documentation for clarity - Added BigIntFilterModule (131.17) to community module size definitions - Increased DateFilterModule size from 132 to 139.28 in module size metrics - Increased GridStateModule size from 14.7 to 17.38 in module size metrics - Increased TextFilterModule size from 124 to 128.66 in module size metrics - Increased AllCommunityModule size from 501.39 to 511.54 in module size metrics - Increased AllEnterpriseModule size from 1606.74 to 1627.32 in module size metrics - Increased FormulaModule size from 88.65 to 92.79 in module size metrics - Increased NewFiltersToolPanelModule size from 175.32 to 180.87 in module size metrics Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * lint Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * update modules.json Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * lint Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * lint and improve bigint handling Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * add some tests Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * fix tests Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * Fix aggregation functions to handle mixed number and bigint types correctly - Updated aggSum to correctly handle mixed number and bigint values by using BigInt when needed - Fixed aggMin to properly compare and return the minimum value between numbers and bigints - Updated aggMax to correctly handle mixed types and return the maximum value - Modified aggAvg to support bigint values in calculations and return appropriate types - Updated test cases to reflect correct behavior for mixed number and bigint inputs - Improved handling of mixed types in aggregation functions to ensure consistent results Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * Fix aggregation functions to handle mixed number and bigint types correctly - Replaced direct BigInt conversion with toBigIntFromNumber helper to ensure proper validation - Added null checks for invalid numbers when converting to bigint - Improved type safety in aggregation functions by using consistent bigint conversion logic - Enhanced error handling for non-finite or non-integer numbers during bigint conversion Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * Update documentation to clarify bigint aggregation behavior Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * Inlined the bigint coercion checks in the aggregation loops and dropped the helper, so the hot paths no longer call toBigIntFromNumber and the performance comment matches the implementation. Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * Updated aggSum, aggMax, and aggAvg to follow the same pattern as aggMin: choose the numeric path based on cellDataType (or a quick scan when not set), then run a dedicated number or bigint loop. This keeps the hot paths aligned with the performance comment and avoids mixing work in a single loop. Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * Use `_jsonEquals` to compare unique values in `setUniqueValues` method - Replace JSON string comparison with `_jsonEquals` for more accurate and efficient value comparison - Simplify logic by removing redundant conditional check Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * Remove unnecessary `_serialiseBigIntValues` calls in server-side row loading - Remove `_serialiseBigIntValues` from `groupKeys` and `filterModel` serialization - Simplify request payload construction by using raw values directly - Improve performance by eliminating redundant serialization steps - Maintain compatibility with existing server-side row model behavior Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * Remove bigint filter model rehydration logic - Replace `bigint` types with `string` in filter model interfaces - Remove `rehydrateBigIntFilterModel` and related helper methods - Simplify state service filter model handling by using raw model directly - Update test expectations to match string-based filter values - Improve type safety by aligning filter model types with serialization format Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * Refactor imports in pivotStage to use direct imports Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * Fix aggregation to correctly detect bigint types in mixed value sets - Update `isBigIntColumn` to include group values and perform type checks on all values - Modify `isBigIntColumn` to return true if any value is a bigint, even if cellDataType is not set - Ensure proper handling of mixed number and bigint values in aggregation functions - Improve type detection logic for better accuracy in bigint identification Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * Remove bigint filter model rehydration logic - Replace `bigint` types with `string` in filter model interfaces - Remove `rehydrateBigIntFilterModel` and related helper methods - Simplify state service filter model handling by using raw model directly - Update test expectations to match string-based filter values - Improve type safety by aligning filter model types with serialization format Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * Fix aggregation to handle mixed number and bigint types correctly - Update `toBigInt` function to handle number inputs and validate against non-finite values - Modify aggregation logic to check value types before processing - Ensure proper handling of mixed number and bigint values in sum operations - Improve type safety by validating input types before conversion - Simplify loop logic by moving type checks outside the main aggregation loop Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * revert some changes Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * update test Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * revert some code Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * revert some code Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * revert some code Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * revert some code Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * use values Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * Update bigint value parser to handle null and empty string values - Update bigint value parser to correctly handle null values - Add check for empty string values and return null - Use _parseBigIntOrNull for parsing valid bigint strings - Improve type safety by checking newValue type before parsing * revert some redundant formatting * refactor some code * remove string validation in bigint parser * - Update `DataTypeService` to handle `bigint` values in value formatting with proper type checks - Improve `BigIntFilterHandler` to use `_parseBigIntOrNull` for validating input values - Add comprehensive tests for `BigIntFilterHandler` covering various filter types and edge cases - Enhance type safety by validating `value` type before parsing - Support null and undefined values in filter operations - Ensure consistent behavior for `bigint` comparisons and filtering * - Replace `toBigIntOrNull` with `_parseBigIntOrNull` for consistent bigint parsing across modules - Add regex validation to ensure only decimal integers are parsed as bigint - Remove unnecessary string validation in bigint parser - Update filter and comparator logic to use `_parseBigIntOrNull` for safe bigint comparison - Refactor test cases to align with updated parsing behavior - Improve type safety by ensuring proper handling of null and empty string values - Simplify code by removing redundant formatting and simplifying conditionals * Remove `_safeJsonStringify` and replace with `JSON.stringify` in Advanced Filter and generic utils - Replace `_safeJsonStringify` with `JSON.stringify` in `advancedFilterBuilderComp.ts` to simplify model stringification - Update `generic.ts` to use `JSON.stringify` in `_jsonEquals` for consistent JSON serialization - Remove unused `_safeJsonStringify` import from `advancedFilterBuilderComp.ts` - Eliminate `bigintJsonReplacer` function as it's no longer needed with standard `JSON.stringify` - Simplify code by removing custom stringification logic, leveraging built-in JSON serialization * Update DataTypeService to handle bigint values in value formatting with proper type checks * refactor a bit * lint * Fix bigint support in advanced filter --------- Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> Co-authored-by: seanlandsman <sean@thelandsmans.com>
* git subrepo pull external/ag-website-shared subrepo: subdir: "external/ag-website-shared" merged: "a013f797c3a" upstream: origin: "git@github.com:ag-grid/ag-website-shared.git" branch: "latest" commit: "a013f797c3a" git-subrepo: version: "0.4.9" origin: "https://github.com/ingydotnet/git-subrepo" commit: "30db3b8" * AG-3390 - Use live sitemap url env var for sitemap generation * AG-3390 - Simplify astro build nx task Do not run the second build for staging. This can be run manually if required.
* AG-16614-fix-tree-data-promotion-to-group-bug
* Add new AI Toolkit Example * Add frameworks * Fix build * Refactor to reduce complexity/size * Simplify gridOptions setting
…s when row selection is enabled (#12931) * Set sourceRowIndex in RowNode creation and update row selectable after row index change Fixes #AG-16479 * Set sourceRowIndex in RowNode creation Fixes #AG-16479 * Set `rowIndex` to `sourceRowIndex` when creating a row node - Set `rowIndex` to `sourceRowIndex` in `ClientSideNodeManager` to ensure correct row index assignment - Remove redundant call to `updateRowSelectable` in `rowIndex` setter as it's no longer needed Fixes #AG-16479 * fix test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )