Skip to content

[pull] latest from ag-grid:latest #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Jan 23, 2026
Merged

[pull] latest from ag-grid:latest #572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5a3d78
AG-16620 Fix examples (#12955)
StephenCooper Jan 23, 2026
424f4a9
Fix threshold reporting (#12958)
StephenCooper Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions ...content/docs/formula-editor-component/_examples/formula-editor-component-disabled/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { ColDef, GetRowIdParams, GridApi, GridOptions, ValueFormatterParams } from 'ag-grid-community';
import type { GetRowIdParams, GridApi, GridOptions, ValueFormatterParams } from 'ag-grid-community';
import {
ClientSideRowModelModule,
ModuleRegistry,
Expand All @@ -19,19 +19,16 @@ ModuleRegistry.registerModules([

let gridApi: GridApi;

const valueFormatter = ({ value }: ValueFormatterParams) => `$ ${Number(value).toFixed(2)}`;
const getRowId = (params: GetRowIdParams) => String(params.data.id);

const columnDefs: ColDef[] = [
{ field: 'item' },
{ field: 'price', valueFormatter },
{ field: 'qty' },
{ field: 'total', allowFormula: true, cellEditor: 'agTextCellEditor', valueFormatter },
];
const currencyFormatter = ({ value }: ValueFormatterParams) => `$ ${Number(value).toFixed(2)}`;

const gridOptions: GridOptions = {
columnDefs,
getRowId,
columnDefs: [
{ field: 'item' },
{ field: 'price', valueFormatter: currencyFormatter },
{ field: 'qty' },
{ field: 'total', allowFormula: true, cellEditor: 'agTextCellEditor', valueFormatter: currencyFormatter },
],
getRowId: (params: GetRowIdParams) => String(params.data.id),
defaultColDef: {
editable: true,
flex: 1,
Expand Down
21 changes: 9 additions & 12 deletions ...docs/src/content/docs/formula-editor-component/_examples/formula-editor-component/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { ColDef, GetRowIdParams, GridApi, GridOptions, ValueFormatterParams } from 'ag-grid-community';
import type { GetRowIdParams, GridApi, GridOptions, ValueFormatterParams } from 'ag-grid-community';
import {
ClientSideRowModelModule,
ModuleRegistry,
Expand All @@ -20,19 +20,16 @@ ModuleRegistry.registerModules([

let gridApi: GridApi;

const valueFormatter = ({ value }: ValueFormatterParams) => `$ ${Number(value).toFixed(2)}`;
const getRowId = (params: GetRowIdParams) => String(params.data.id);

const columnDefs: ColDef[] = [
{ field: 'item' },
{ field: 'price', valueFormatter },
{ field: 'qty' },
{ field: 'total', allowFormula: true, valueFormatter },
];
const currencyFormatter = ({ value }: ValueFormatterParams) => `$ ${Number(value).toFixed(2)}`;

const gridOptions: GridOptions = {
columnDefs,
getRowId,
columnDefs: [
{ field: 'item' },
{ field: 'price', valueFormatter: currencyFormatter },
{ field: 'qty' },
{ field: 'total', allowFormula: true, valueFormatter: currencyFormatter },
],
getRowId: (params: GetRowIdParams) => String(params.data.id),
cellSelection: {
handle: {
mode: 'fill',
Expand Down
18 changes: 9 additions & 9 deletions scripts/ci/compare-module-sizes.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env node
import fs from 'node:fs';

const THRESHOLD_PERCENT = 0.5; // Ignore changes below this percentage
const THRESHOLD = 0.5; // Ignore changes below this size change
const HIGHLIGHT_PERCENT = 5; // Highlight table rows when change exceeds this percentage

/**
Expand Down Expand Up @@ -169,7 +169,7 @@ const maxIncrease = diffs.reduce((max, d) => (d.selfSizeDiff > max.selfSizeDiff
const maxDecrease = diffs.reduce((min, d) => (d.selfSizeDiff < min.selfSizeDiff ? d : min), diffs[0]);

// Filter significant changes
const significantChanges = diffs.filter((d) => Math.abs(d.selfSizePercent) >= THRESHOLD_PERCENT);
const significantChanges = diffs.filter((d) => Math.abs(d.selfSizeDiff) >= THRESHOLD);

// Generate markdown report
let report = '';
Expand All @@ -180,8 +180,8 @@ report += '## Module Size Comparison\n\n';
// Extremes section - only show if change is >= THRESHOLD_PERCENT
report += '### Extreme Values\n\n';

const showMaxIncrease = maxIncrease && maxIncrease.selfSizePercent >= THRESHOLD_PERCENT;
const showMaxDecrease = maxDecrease && maxDecrease.selfSizePercent <= -THRESHOLD_PERCENT;
const showMaxIncrease = maxIncrease && maxIncrease.selfSizeDiff >= THRESHOLD;
const showMaxDecrease = maxDecrease && maxDecrease.selfSizeDiff <= -THRESHOLD;

if (showMaxIncrease) {
const moduleName = maxIncrease.modules.length === 0 ? 'Base (no modules)' : maxIncrease.modules.join(', ');
Expand All @@ -196,12 +196,12 @@ if (showMaxDecrease) {
}

if (!showMaxIncrease && !showMaxDecrease) {
report += `✅ No significant changes (all changes < ${THRESHOLD_PERCENT}%)\n\n`;
report += `✅ No significant changes (all changes < ${THRESHOLD}KB)\n\n`;
}

// Significant changes table
if (significantChanges.length > 0) {
report += `### Significant Changes (≥ ${THRESHOLD_PERCENT}%)\n\n`;
report += `### Significant Changes (≥ ${THRESHOLD}KB)\n\n`;
report +=
'| Module(s) | Base (KB) | PR (KB) | Diff (KB) | Diff % | Base Gzip (KB) | PR Gzip (KB) | Gzip Diff (KB) | Gzip % |\n';
report +=
Expand Down Expand Up @@ -230,7 +230,7 @@ if (significantChanges.length > 0) {
report += '\n';
} else {
report += '### Significant Changes\n\n';
report += `✅ No modules changed by more than ${THRESHOLD_PERCENT}%.\n\n`;
report += `✅ No modules changed by more than ${THRESHOLD}KB.\n\n`;
}

// New/Removed modules
Expand Down Expand Up @@ -302,7 +302,7 @@ console.log(`Comparison report written to ${outputFile}`);

// Output summary for CI
console.log('\n--- Summary ---');
console.log(`Significant changes (>= ${THRESHOLD_PERCENT}%): ${significantChanges.length}`);
console.log(`Significant changes (>= ${THRESHOLD}KB): ${significantChanges.length}`);
if (showMaxIncrease) {
const moduleName = maxIncrease.modules.length === 0 ? 'Base (no modules)' : maxIncrease.modules.join(', ');
console.log(
Expand All @@ -316,5 +316,5 @@ if (showMaxDecrease) {
);
}
if (!showMaxIncrease && !showMaxDecrease) {
console.log(`No significant module size changes detected (all < ${THRESHOLD_PERCENT}%).`);
console.log(`No significant module size changes detected (all < ${THRESHOLD}KB).`);
}
Loading