[pull] main from cloudflare:main #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(wrangler): return correct config filename for .jsonc files The configFormat function was collapsing both .json and .jsonc files into a single "jsonc" format value. This caused configFileName to always return "wrangler.json" even when users had a wrangler.jsonc file, resulting in misleading error messages and documentation hints. Now configFormat distinguishes between "json" and "jsonc" formats, allowing configFileName to return the correct filename for each. * add changeset * update snapshots for jsonc config filename * address review comments: refactor config format handling - Use early returns instead of else-if in configFormat - Use switch statement in configFileName - Add JSON_CONFIG_FORMATS constant as single source of truth - Use JSON_CONFIG_FORMATS.includes() instead of format === 'json' || format === 'jsonc' - Add tests for configFormat and configFileName functions * fix type error: widen type for includes() check * type JSON_CONFIG_FORMATS as readonly string[] to avoid type assertions
The quick-edit deployment does not hit the production dashboard until a change is made to the internal dashboard project, so it is safe to deploy this worker via the changeset-triggered deployment process.
…to Sentry (#11922) * Ensure that `wrangler init` includes C3 error details when reporting to Sentry Currently when `wrangler init` delegates to C3 and an error occurs the information sent to Sentry lacks in details, making diagnosing the potential problem impossible, the changes here ensure that the C3 stdout and stderr are instead included in the error Sentry receives * Add changeset * update changeset to be a minor bump
* Notify when security advisories are submitted to workers-sdk * Use repository_advisory event instead of security_advisory * add description to body * Add devprod status bot to COFS exceptions
…rld templates from `^0.8.19` to `^0.12.4` (#11952)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )