[pull] main from cloudflare:main #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6`) to Cloudflare OAuth API, even when the `--callback-host` and `--callback-port` params would not be accepted (#9396) * Always pass a valid `redirect_uri` callback parameter (`localhost:8976`) to Cloudflare OAuth API, even when the `--callback-host` and `--callback-port` params would not be accepted. The OAuth provider only accepts `localhost:8976` as the host and port in the `redirect_uri` parameter of the login request. One can configure the Wrangler's OAuth callback server to listen on custom host, via `--callback-host` (e.g. 0.0.0.0 or 127.0.0.1), and port, via `--callback-port`. This is useful when running Wrangler inside a Docker container (or equivalent) where it is not possible to listen on `localhost`. In this case, you can configure Wrangler to listen on a different host and/or port but then it is up to you to configure your container to map `localhost:8976` to the host and port on which Wrangler is listening. **Example:** Running the callback server on `127.0.0.1:8989`: ``` wrangler login --calback-host=127.0.0.1 --callback-port=8989 ``` results in Wrangler listening on 127.0.0.1:8989 and a login URL that looks like: ``` https://dash.cloudflare.com/oauth2/auth?...&redirect_uri=http%3A%2F%2Flocalhost%3A8976%2Foauth%2Fcallback&... ``` Note that the `redirect_uri` is always `localhost:8976` whatever the callback host and port are. * Update .changeset/curly-peas-hunt.md Co-authored-by: emily-shen <69125074+emily-shen@users.noreply.github.com> --------- Co-authored-by: Edmund Hung <me@edmund.dev> Co-authored-by: emily-shen <69125074+emily-shen@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )