[pull] main from cloudflare:main #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#12024) Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>
#12030) * Add support for increased Pages max asset limit in the pages validate command * Update .changeset/clever-cloths-push.md Co-authored-by: Edmund Hung <me@edmund.dev> --------- Co-authored-by: Edmund Hung <me@edmund.dev>
* ci: make changeset review non-blocking Claude will still post a review comment to the PR, but the workflow will no longer fail if issues are found. This allows human reviewers to decide whether to address the feedback. Also removed structured JSON output in favor of human-readable comments. * docs: clarify changeset length and examples guidelines - Changesets should be more than one sentence but less than three paragraphs (unless the change is very large) - Code examples are encouraged but not mandatory - Updated CI workflow prompt to align with new guidelines * ci: defer to author's choice on changeset version type Claude should accept the author's choice of patch/minor unless it's clearly incorrect, rather than being prescriptive.
* Added initial binding type aggregation fix * Minor refactoring * Added aggregate binding types changeset * temporarily disable media binding test (#11900) * Updated changeset description * Added JSDoc description to `generateEnvTypes` * Minor type generation refactoring * Minor `collectEnvironmentVars` refactoring * Added `getEnvConfig` helper to handle environment config validation * Minor `generateEnvTypes` refactoring * Removed optional syntax from JSDoc parameters * Renamed `collectAllBindings` to `collectCoreBindings` * Fixed CI test inline snapshots * Fixed invalid config parsing errors * Minor refactoring * Added basic unit tests for `throwMissingBindingError` * Overhauled binding type aggregation logic + added scoped environment env interfaces * Added changeset * Minor type generation test cleanup * Minor type generation test cleanup * Minor JSDoc tweaks * Minor type generation logic cleanup * Minor refactoring test fixes * Minor JSDoc fixes * Added `getEnvHeader` helper * Cleaned up `getEnvHeader` usage * Added basic unit tests for `getEnvHeader` * Renamed `checkPath` to `validateTypesFile` * Improved JSDoc comments for `validateTypesFile` * Refactored `throwMissingBindingError` to use options parameter * Updated `index` option to make it optional * Replaced `Array<string>` with `string[]` * Unified to-level sentinel key * Add basic example to changeset --------- Co-authored-by: emily-shen <69125074+emily-shen@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )