[pull] canary from vercel:canary #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think overall it's not appropriate to add Vercel-specific caveats to these guides because they make it look like they're upselling Vercel. I've edited to emphasize the self-hosting condition instead, from which one should be able to infer it doesn't apply to Vercel. Co-authored-by: Joseph <joseph.chamochumbi@vercel.com>
Small follow-up to #86591. We don't need to recreate the server module map proxy every time we set the manifests singleton. Instead, we can just update the underlying server actions manifest, and the server module map can read the current manifest from the singleton.
…atic import) (#86485) In a previous PR #73184 the `?dpl` query string was added to local images from static imports but not to images without the static import. This was a subtle change based on malte's PR review comment here: #73184 (comment) However, I can't think of reason why we should differentiate these two since they are both related to the current deployment (as opposed to remote images which live outside the deployment). Furthermore, this string matching is causing microfrontends to fail to add the `?dpl` because they have a path prefix and thus fail skew protection. So this PR fixes both problems by loosening the string matching to look for src images that start with `/`.
This auto-generated PR updates the development integration test manifest used when testing Rspack.
) Add helpers for using bincode with various commonly-used foreign types that do not implement `bincode::Encode`/`bincode::Decode`. We can't implement the bincode traits on these types ourselves because of the orphan rules. This is pulled out of #85878 to make it easier to review. This depends on my fork of bincode here: https://github.com/bgw/bincode/commits/bgw/patches/ Specifically, the `with =` attribute I added here: bgw/bincode@4103717 This behaves like the serde equivalent: https://serde.rs/field-attrs.html#with I am working on trying to get the changes with the bincode fork upstreamed. I submitted a bugfix (bgw/bincode@9247286) via email to the maintainer to start. Upstream is hosted at https://git.sr.ht/~stygianentity/bincode and my fork there is at https://git.sr.ht/~bgw/bincode .
We (unsurprisingly) spend a lot of time encoding `Rope`s. Most of this is in `memcpy`ing the data out of the rope (not easy to optimize), but there's some cloning of refcounted `Bytes` containers here that can be easily avoided. Yes, `Bytes` is refcounted, but updating refcounts isn't free, and it matters because this is a hot codepath. This is too small to show up on any top-line measurement (<1%) of total time, but should still be an improvement.
Add Firebase App Hosting to the list of adapters in the [deployment guide](https://nextjs.org/docs/app/getting-started/deploying#adapters). <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Co-authored-by: JJ Kasper <jj@jjsweb.site>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )