[pull] canary from vercel:canary #719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…C deploy tests (#88824) Part of https://linear.app/vercel/issue/NAR-719/ We previously only supported a single manifest for filtering tests. However, Cache Component deploy tests have two manifests. Now we merge manifests append-only. ## Test plan - [x] #88821 adds a failed deploy test to a test suite also listed in the CC manifest. Tests from CC and deploy manifest are skipped ```console $ NEXT_EXTERNAL_TESTS_FILTERS="test/deploy-tests-manifest.json,test/cache-components-tests-manifest.json" NEXT_TEST_MODE=deploy node run-tests.js -c 1 --retries 0 test/e2e/app-dir/searchparams-reuse-loading/searchparams-reuse-loading.test.ts ○ skipped should re-use loading from "full" prefetch for param-full URL when navigating to param-less route ○ skipped should re-use loading from "full" prefetch for param-less URL when navigating to param-full route ○ skipped should re-use loading from "full" prefetch for param-full URL when navigating to param-full route when aliasing is skipped ✕ should work for not found pages ✕ should work for route handlers ✕ should work for navigating to pages dir Without Middleware ✕ should correctly return different RSC data for full prefetches with different searchParam values With Middleware ○ skipped should correctly return different RSC data for full prefetches with different searchParam values ```
…nction points (#88192) This is a crappy fuzzer I have to make sure that the filesystem watcher picks up changes to files. This didn't have coverage for links, so this tests that. I tested this on Windows and Linux. I don't care about the code quality here, so this was LLM-generated with very lightweight review.
…88829) When digging into failing deployment tests, I often will re-run the test itself without wanting to change anything about Next.js or the test application, especially when I suspect a logic bug in the test itself or need to figure out what's causing a flake. This adds an environment variable that can be used to skip the build/deploy step and will use an existing deployment URL to run the tests against. I suggest reviewing this [without whitespace](https://github.com/vercel/next.js/pull/88829/changes?w=1).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )