[pull] canary from vercel:canary #742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Improve route handler "no response" error message for debugging ### What? Improves the error message thrown when an app route handler doesn't return a `Response` object to include additional debugging information: - **The actual type received** - Shows whether it was `null`, `undefined`, or the constructor name for objects - **The HTTP method** - e.g., `GET`, `POST` - **The URL pathname** - The route being requested ### Why? When debugging intermittent prerender failures like: ``` Error: No response is returned from route handler '[project]/apps/web/app/favicon--route-entry.js'. ``` It was unclear what the handler actually returned. This made it difficult to diagnose whether: - The handler returned `undefined` (didn't return anything) - The handler returned `null` (explicit null) - The handler returned some other object type (module loading issue) ### How? Updated the error message format from: ``` No response is returned from route handler '/path/route.ts'. Ensure you return a `Response` or a `NextResponse` in all branches of your handler. ``` To: ``` No response is returned from route handler '/path/route.ts'. Expected a Response object but received 'undefined' (method: GET, url: /favicon.ico). Ensure you return a `Response` or a `NextResponse` in all branches of your handler. ``` ### Changes - `packages/next/src/server/route-modules/app-route/module.ts` - Enhanced error with type detection and request context - `packages/next/errors.json` - Updated error template - `test/e2e/app-dir/app-routes/app-custom-routes.test.ts` - Updated test to match new error format
### What? * allow to pass PR number * fetch PR reviews * Rename to /pr-status update agent instructions
* add general comments * remove full log to avoid the agent accessing it * add PR number argument
## Summary Renames the CI job display names from 'Test new tests' to 'Test new and changed tests' to accurately reflect what these jobs do. The `get-changed-tests.mjs` script uses `git diff --name-only` which detects both added and modified files, so the job names should reflect that they test both new AND changed test files.
### What? Adds support for TypeScript PostCSS configuration files in Turbopack. ### Why? Users can write their PostCSS configuration in TypeScript for better type safety and IDE support. This was already supported in webpack but was missing in Turbopack. ### How? Added the following TypeScript config file names to Turbopack's PostCSS config detection: - `postcss.config.ts`, `postcss.config.mts`, `postcss.config.cts` - `.postcssrc.ts`, `.postcssrc.mts`, `.postcssrc.cts` - `.config/postcssrc.ts`, `.config/postcssrc.mts`, `.config/postcssrc.cts` Also updated the Turbopack documentation to reflect the supported config file extensions (`.js`, `.mjs`, `.cjs`, `.ts`, `.mts`, `.cts`). ### Testing Added e2e tests that verify the TypeScript PostCSS config is actually loaded and applied by using a custom plugin that transforms colors. Tests cover: - `postcss.config.ts` - `postcss.config.mts` - `postcss.config.cts` - `.postcssrc.ts`
Follow-up to #88824. When merging multiple test manifests, a test file may be included in `suites` by one manifest, but excluded in `rules` by another. This change ensures that if a test file is excluded by filename (and not by pattern), the exclusion takes precedence over the inclusion. Specifically, this allows us to skip Cache Components deploy tests via the `exclude` rules in `cache-components-tests-manifest.json`, even though those may be included in the `suites` of `deploy-tests-manifest.json`. Alternatively, we could maintain separate deploy tests manifests for Cache Components and non-Cache Components deploy tests.
This prevents stack overflow errors when malicious payloads include a large number of arguments.
### What? The rule system should handle the import as json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )