[pull] main from facebook:main #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary This PR upgrades the dependency on update-notifier, used in react-devtools, to 5.x This is the latest non-ESM version, so upgrading to it should be unproblematic (while updating to 6.x and beyond will have to wait). Upgrading means we avoid installing a lot of outdated dependencies (as can be seen from the diff in yarn.lock), and resolves part of #28058 Changelog: https://github.com/yeoman/update-notifier/releases The most relevant breaking change seems to be that the minimum support node version is increased from v6 to v10, but I couldn't find what is currently React's official node version support. ## How did you test this change? I ran the test-suite locally (`yarn test` in root folder), but I'm not sure if that one actually covers devtools? I also built and tested this version of devtools with some internal company projects (both react and react-native based) – following guidelines from #28058 (comment).
If an error is thrown inside a hidden Activity, it should not escape into the visible part of the UI. Conceptually, a hidden Activity boundary is not part of the current UI; it's the same as an unmounted tree, except for the fact that the state will be restored if it's later revealed. Fixes: - #35073
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )