fix bug

Author: kobenguyent

lib/container.js

@@ -202,15 +202,6 @@ class Container {
   static append(newContainer) {
     container = deepMerge(container, newContainer)
 
-    // If new helpers are added, set the helpers property on them
-    if (newContainer.helpers) {
-      for (const name in newContainer.helpers) {
-        if (container.helpers[name] && typeof container.helpers[name] === 'object') {
-          container.helpers[name].helpers = container.helpers
-        }
-      }
-    }
-
     // If new support objects are added, update the proxy support
     if (newContainer.support) {
       const newProxySupport = createSupportObjects(newContainer.support)
@@ -301,7 +292,7 @@ async function createHelpers(config) {
       if (!HelperClass) {
         const helperResult = requireHelperFromModule(helperName, config)
         if (helperResult instanceof Promise) {
-          // Handle async ESM loading
+          // Handle async ESM loading - create placeholder
           helpers[helperName] = {}
           asyncHelperPromise = asyncHelperPromise
             .then(() => helperResult)
@@ -320,8 +311,7 @@ async function createHelpers(config) {
 
               checkHelperRequirements(ResolvedHelperClass)
               helpers[helperName] = new ResolvedHelperClass(config[helperName])
-              if (helpers[helperName]._init) await helpers[helperName]._init()
-              debug(`helper ${helperName} async initialized`)
+              debug(`helper ${helperName} async loaded`)
             })
           continue
         } else {
@@ -341,9 +331,8 @@ async function createHelpers(config) {
               throw new Error(`Helper class from module '${helperName}' is not a class. Use CJS async module syntax.`)
             }
 
-            debug(`helper ${helperName} async initialized`)
-
             helpers[helperName] = new ResolvedHelperClass(config[helperName])
+            debug(`helper ${helperName} async CJS loaded`)
           })
 
         continue
@@ -358,19 +347,17 @@ async function createHelpers(config) {
     }
   }
 
-  // Set helpers property on each helper to allow access to other helpers
-  for (const name in helpers) {
-    if (helpers[name] && typeof helpers[name] === 'object') {
-      helpers[name].helpers = helpers
-    }
-  }
-
-  // Wait for async helpers and call _init
+  // Wait for all async helpers to be fully loaded
   await asyncHelperPromise
 
+  // Call _init on all helpers after they're all loaded
   for (const name in helpers) {
-    if (helpers[name]._init) await helpers[name]._init()
+    if (helpers[name]._init) {
+      await helpers[name]._init()
+      debug(`helper ${name} _init() called`)
+    }
   }
+
   return helpers
 }
 

lib/helper/REST.js

@@ -468,7 +468,8 @@ class REST extends Helper {
 export { REST as default }
 
 function curlize(request) {
-  if (request.data?.constructor.name.toLowerCase() === 'formdata') return 'cURL is not printed as the request body is not a JSON'
+  // Guard access to nested properties safely in case request.data is undefined
+  if ((request.data?.constructor?.name || '').toLowerCase() === 'formdata') return 'cURL is not printed as the request body is not a JSON'
   let curl = `curl --location --request ${request.method ? request.method.toUpperCase() : 'GET'} ${request.baseURL} `.replace("'", '')
 
   if (request.headers) {