Skip to content

Commit b7db169

Browse files
committed
refactor: remove redundant acceptance-tests workflow and fix webdriver workflow
Changes: - Disabled acceptance-tests.yml (renamed to .disabled) - This workflow only ran WebDriverIO tests in Docker - These same tests are already run by webdriver.yml natively - Docker overhead not needed for these tests - Fixed webdriver.yml: - Removed duplicate PHP server start (was started twice) - Changed grep from @webdriver to @webdriverio for clarity - Added SELENIUM env vars to acceptance tests step - Tests now run more efficiently without Docker Rationale: - webdriver.yml runs WebDriver helper unit tests + WebDriverIO acceptance tests - No need to duplicate the same acceptance tests in Docker - Reduces CI time and complexity
1 parent 8f5d316 commit b7db169

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed
File renamed without changes.

.github/workflows/webdriver.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,17 +54,16 @@ jobs:
5454
GH_PAT: ${{ github.token }}
5555
SELENIUM_HOST: localhost
5656
SELENIUM_PORT: 4444
57-
- name: start a server
58-
run: |
59-
php -S 0.0.0.0:8000 -t test/data/app &
60-
sleep 5
6157
- name: run unit tests
6258
run: ./node_modules/.bin/mocha test/helper/WebDriver_test.js --exit --reporter @testomatio/reporter/mocha
6359
timeout-minutes: 10
6460
env:
6561
SELENIUM_HOST: localhost
6662
SELENIUM_PORT: 4444
67-
- name: run tests
68-
run: './bin/codecept.js run -c test/acceptance/codecept.WebDriver.js --grep @WebDriver --debug'
63+
- name: run acceptance tests
64+
run: './bin/codecept.js run -c test/acceptance/codecept.WebDriver.js --grep @WebDriverIO --debug'
65+
env:
66+
SELENIUM_HOST: localhost
67+
SELENIUM_PORT: 4444
6968
- name: Stop mock server
7069
run: npm run mock-server:stop

0 commit comments

Comments
 (0)