improve Dockerfile #4994
Closed
improve Dockerfile #4994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomashohn
approved these changes
May 17, 2025
Contributor
thomashohn
left a comment
thomashohn
left a comment
There was a problem hiding this comment.
Besides the failing tests it looks fine
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Dockerfile to use a newer Playwright base image and refines dependency installation and user management for improved security and reproducibility.
- Updated base image version and environment variable syntax
- Refactored apt-get commands, user creation, and dependency installation steps
- Adjusted working directories and file copying to separate application and test areas
Comment on lines
35
to
36
| WORKDIR /tests | ||
|
|
There was a problem hiding this comment.
The COPY instruction is executed when the working directory is set to /codecept, but later the WORKDIR is changed to /tests. Please clarify if the project files should reside in both directories or adjust the file copying to correctly reflect the intended structure.
Suggested change
| WORKDIR /tests |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)