-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
✅ Sentry found no issues in your recent changes ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1212 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 457 457
Lines 37089 37089
=======================================
Hits 36238 36238
Misses 851 851
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| "skip_count", | ||
| ("computed_name", pl.Utf8), | ||
| ("testsuite", pl.Utf8), | ||
| ("flags", pl.List(pl.Utf8)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is still defined as pl.String in the above "no version" schema.
What is the difference between these two anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping that this was some stricter version of string that enforced the encoding but alas after looking at the docs there is no difference its just an alias, i'll switch it it back since String is more clear
seeing an error in sentry where polars is unable to infer the schema because the computed_name is null for a bunch of testruns 2 things: - i don't want the computed name to be null (in the future this logic should live in the test results parser lib) - the polars schema should've been verbose about types from the start to avoid schema inference issues
23a5edf to
dc86985
Compare
seeing an error in sentry where polars is unable to infer the schema because the computed_name is null for a bunch of testruns
2 things: