Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Conversation

@joseph-sentry
Copy link
Contributor

since we've observed a bit of replication lag between the primary and the TA read replica i just want to ensure we make these important reads from the primary to avoid any read-after-write inconsistencies

since we've observed a bit of replication lag between the primary
and the TA read replica i just want to ensure we make these important
reads from the primary to avoid any read-after-write inconsistencies
@sentry
Copy link

sentry bot commented Apr 23, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: services/test_analytics/ta_processor.py

Function Unhandled Issue
ta_processor_impl ReportSession.DoesNotExist: ReportSession matching query does not exist. app.tasks.test_resu...
Event Count: 101

Did you find this useful? React with a 👍 or 👎

@seer-by-sentry
Copy link
Contributor

🚨 Sentry detected 1 potential issue in your recent changes 🚨

Lower risk findings

Did you find this useful? React with a 👍 or 👎

@codecov-notifications
Copy link

codecov-notifications bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (eae0b7d) to head (4e3521d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1220   +/-   ##
=======================================
  Coverage   97.74%   97.74%           
=======================================
  Files         459      459           
  Lines       37296    37296           
=======================================
  Hits        36454    36454           
  Misses        842      842           
Flag Coverage Δ
integration 42.72% <0.00%> (ø)
unit 90.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joseph-sentry joseph-sentry requested a review from a team April 23, 2025 19:58
@joseph-sentry joseph-sentry enabled auto-merge April 23, 2025 21:12
@joseph-sentry joseph-sentry added this pull request to the merge queue Apr 24, 2025
Merged via the queue into main with commit 9de1f0d Apr 24, 2025
28 of 30 checks passed
@joseph-sentry joseph-sentry deleted the joseph/replication branch April 24, 2025 07:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants