refactor(delete-button): remove redundant progress indicator assertions in delete tests [percy]

Author: andy1li

tests/acceptance/concept-admin/delete-concept-test.js

@@ -36,9 +36,7 @@ module('Acceptance | concept-admin | delete-concept-test', function (hooks) {
 
     await basicDetailsPage.deleteConceptModal.deleteConceptButton.mousedown();
     assert.ok(basicDetailsPage.deleteConceptModal.deleteConceptButton.progressIndicator.isVisible, 'progress indicator should be visible');
-
     await waitUntil(() => basicDetailsPage.deleteConceptModal.deleteConceptButton.progressIndicator.width > 0, { timeout: 10 });
-    assert.ok(basicDetailsPage.deleteConceptModal.deleteConceptButton.progressIndicator.width > 0, 'progress indicator should have a width');
 
     await waitUntil(() => currentURL() === '/concepts');
     await settled(); // Delete request triggers after redirect
@@ -74,9 +72,7 @@ module('Acceptance | concept-admin | delete-concept-test', function (hooks) {
 
     await basicDetailsPage.deleteConceptModal.deleteConceptButton.mousedown();
     assert.ok(basicDetailsPage.deleteConceptModal.deleteConceptButton.progressIndicator.isVisible, 'progress indicator should be visible');
-
     await waitUntil(() => basicDetailsPage.deleteConceptModal.deleteConceptButton.progressIndicator.width > 0, { timeout: 10 });
-    assert.ok(basicDetailsPage.deleteConceptModal.deleteConceptButton.progressIndicator.width > 0, 'progress indicator should have a width');
 
     await waitUntil(() => currentURL() === '/concepts');
     await settled(); // Delete request triggers after redirect

tests/acceptance/course-page/delete-repository-test.js

@@ -152,9 +152,7 @@ module('Acceptance | course-page | delete-repository-test', function (hooks) {
 
     await coursePage.deleteRepositoryModal.deleteRepositoryButton.mousedown();
     assert.ok(coursePage.deleteRepositoryModal.deleteRepositoryButton.progressIndicator.isVisible, 'progress indicator should be visible');
-
     await waitUntil(() => coursePage.deleteRepositoryModal.deleteRepositoryButton.progressIndicator.width > 0, { timeout: 10 });
-    assert.ok(coursePage.deleteRepositoryModal.deleteRepositoryButton.progressIndicator.width > 0, 'progress indicator should have a width');
 
     await waitUntil(() => currentURL() === '/courses/dummy/introduction?repo=new&track=python');
     await settled(); // Delete request triggers after redirect
@@ -190,9 +188,7 @@ module('Acceptance | course-page | delete-repository-test', function (hooks) {
 
     await coursePage.deleteRepositoryModal.deleteRepositoryButton.touchstart();
     assert.ok(coursePage.deleteRepositoryModal.deleteRepositoryButton.progressIndicator.isVisible, 'progress indicator should be visible');
-
     await waitUntil(() => coursePage.deleteRepositoryModal.deleteRepositoryButton.progressIndicator.width > 0, { timeout: 10 });
-    assert.ok(coursePage.deleteRepositoryModal.deleteRepositoryButton.progressIndicator.width > 0, 'progress indicator should have a width');
 
     await waitUntil(() => currentURL() === '/courses/dummy/introduction?repo=new&track=python');
     await settled(); // Delete request triggers after redirect