Fix: Move <h2> outside of <ul> for improved semantic structure#49
Open
Anjalisharma8072 wants to merge 2 commits intocodedex-io:mainfrom
Open
Fix: Move <h2> outside of <ul> for improved semantic structure#49Anjalisharma8072 wants to merge 2 commits intocodedex-io:mainfrom
Anjalisharma8072 wants to merge 2 commits intocodedex-io:mainfrom
Conversation
Member
|
Hi Anjali! This is a great catch. Looks like prettier adjusted the formatting as well. However, because the code is in the CSS pre-loaded. We'd need to fix that as well. So going to backlog this for now, but going to keep the PR~ |
Author
|
okay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a structural bug in the HTML code where the h2 heading for "My Feed" was incorrectly placed inside the ul element.
Solution:
Placing heading elements inside a list can lead to confusion regarding the document structure and may affect accessibility for screen readers. By positioning the h2 correctly, I enhance the readability and semantics of the HTML document, ensuring that it accurately reflects the content hierarchy