-
Notifications
You must be signed in to change notification settings - Fork 22
feat: Add Line Profiler to webapp #1139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HeshamHM28
wants to merge
2
commits into
main
Choose a base branch
from
feat/line/profiler/webApp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -171,6 +171,8 @@ def suggest_changes( | |
| replay_tests: str = "", | ||
| concolic_tests: str = "", | ||
| optimization_review: str = "", | ||
| original_line_profiler: str = "", | ||
| optimized_line_profiler: str = "", | ||
| ) -> Response: | ||
| """Suggest changes to a pull request. | ||
|
|
||
|
|
@@ -182,6 +184,8 @@ def suggest_changes( | |
| :param file_changes: A dictionary of file changes. | ||
| :param pr_comment: The pull request comment object, containing the optimization explanation, best runtime, etc. | ||
| :param generated_tests: The generated tests. | ||
| :param original_line_profiler: Line profiler results for original code (markdown format). | ||
| :param optimized_line_profiler: Line profiler results for optimized code (markdown format). | ||
| :return: The response object. | ||
| """ | ||
| payload = { | ||
|
|
@@ -198,6 +202,13 @@ def suggest_changes( | |
| "concolicTests": concolic_tests, | ||
| "optimizationReview": optimization_review, # impact keyword left for legacy reasons, touches js/ts code | ||
| } | ||
|
|
||
| # Add line profiler data if available | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no longer needed if you default the argument to None |
||
| if original_line_profiler: | ||
| payload["originalLineProfiler"] = original_line_profiler | ||
| if optimized_line_profiler: | ||
| payload["optimizedLineProfiler"] = optimized_line_profiler | ||
|
|
||
| return make_cfapi_request(endpoint="/suggest-pr-changes", method="POST", payload=payload) | ||
|
|
||
|
|
||
|
|
@@ -214,6 +225,8 @@ def create_pr( | |
| replay_tests: str = "", | ||
| concolic_tests: str = "", | ||
| optimization_review: str = "", | ||
| original_line_profiler: str = "", | ||
| optimized_line_profiler: str = "", | ||
| ) -> Response: | ||
| """Create a pull request, targeting the specified branch. (usually 'main'). | ||
|
|
||
|
|
@@ -223,6 +236,8 @@ def create_pr( | |
| :param file_changes: A dictionary of file changes. | ||
| :param pr_comment: The pull request comment object, containing the optimization explanation, best runtime, etc. | ||
| :param generated_tests: The generated tests. | ||
| :param original_line_profiler: Line profiler results for original code (markdown format). | ||
| :param optimized_line_profiler: Line profiler results for optimized code (markdown format). | ||
| :return: The response object. | ||
| """ | ||
| # convert Path objects to strings | ||
|
|
@@ -240,6 +255,13 @@ def create_pr( | |
| "concolicTests": concolic_tests, | ||
| "optimizationReview": optimization_review, # Impact keyword left for legacy reasons, it touches js/ts codebase | ||
| } | ||
|
|
||
| # Add line profiler data if available | ||
| if original_line_profiler: | ||
| payload["originalLineProfiler"] = original_line_profiler | ||
| if optimized_line_profiler: | ||
| payload["optimizedLineProfiler"] = optimized_line_profiler | ||
|
|
||
| return make_cfapi_request(endpoint="/create-pr", method="POST", payload=payload) | ||
|
|
||
|
|
||
|
|
@@ -269,6 +291,8 @@ def create_staging( | |
| concolic_tests: str, | ||
| root_dir: Path, | ||
| optimization_review: str = "", | ||
| original_line_profiler: str = "", | ||
| optimized_line_profiler: str = "", | ||
| ) -> Response: | ||
| """Create a staging pull request, targeting the specified branch. (usually 'staging'). | ||
|
|
||
|
|
@@ -279,6 +303,8 @@ def create_staging( | |
| :param generated_original_test_source: Generated tests for the original function. | ||
| :param function_trace_id: Unique identifier for this optimization trace. | ||
| :param coverage_message: Coverage report or summary. | ||
| :param original_line_profiler: Line profiler results for original code (markdown format). | ||
| :param optimized_line_profiler: Line profiler results for optimized code (markdown format). | ||
| :return: The response object from the backend. | ||
| """ | ||
| relative_path = explanation.file_path.relative_to(root_dir).as_posix() | ||
|
|
@@ -312,6 +338,12 @@ def create_staging( | |
| "optimizationReview": optimization_review, # Impact keyword left for legacy reasons, it touches js/ts codebase | ||
| } | ||
|
|
||
| # Add line profiler data if available | ||
| if original_line_profiler: | ||
| payload["originalLineProfiler"] = original_line_profiler | ||
| if optimized_line_profiler: | ||
| payload["optimizedLineProfiler"] = optimized_line_profiler | ||
|
|
||
| return make_cfapi_request(endpoint="/create-staging", method="POST", payload=payload) | ||
|
|
||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.