Resolved Conflicts#96
Conversation
There was a problem hiding this comment.
-
I suggest you use the code formator preferred in the codebase to indent all styles in one go. if you use VScode simply install mentioned code formator Extention to format it easily. Maybe in this you need to install "prettier" not sure
-
Review function once you missed adding arrow-parens at some places
-
Remove unused code as it is mention in the test report that in line no. 215 and 216 you defined id, s, name, value but never reused them.
src/components/CreateNewEvent.js
Outdated
| <div className={classes.root}> | ||
| <DrawerLayout> | ||
| <div className={classes.root}> | ||
| <ValidatorForm onSubmit={handleSubmit} onError={errors => console.log(errors)}> |
src/components/CreateNewEvent.js
Outdated
| <InputBase | ||
| className={classes.social} | ||
| <TextValidator | ||
| key="linkedIn" |
There was a problem hiding this comment.
indentation error use preferred code formator to resolve all indent-related errors in one go.
There was a problem hiding this comment.
I already formatted the code with prettier but ok I am doing changes.
src/components/CreateNewEvent.js
Outdated
| /> | ||
| </fieldset> | ||
| ))} | ||
| ))} |
There was a problem hiding this comment.
indentation error and no-trailing-spaces allowed acc to preferred code formator
src/components/CreateNewEvent.js
Outdated
| </Box> | ||
| </ValidatorForm> | ||
| </div> | ||
| </DrawerLayout> |
| import { | ||
| Box, Button, Grid, makeStyles | ||
| } from '@material-ui/core'; | ||
| import { Box, Button, Grid, makeStyles } from '@material-ui/core'; |
There was a problem hiding this comment.
object-curly-newline according to code formator revert this as it is.
| import { useHistory } from 'react-router-dom'; | ||
|
|
||
| const useStyles = makeStyles((theme) => ({ | ||
| const useStyles = makeStyles(theme => ({ |
There was a problem hiding this comment.
This all codes are not written by me that's why I am facing more problem.
There was a problem hiding this comment.
one thing I want to suggest is that please try to cover all the errors in a single commit.
if you want to confirm that all errors are resolved or not simply see your PowerShell window from where you run the `npm start command. if it says that localhost is running on port 3000 after compilation then errors are resolved otherwise it will show you the errors in the PowerShell window with the line number. Other than this method you can also check the console by opening inspect windows on your react application, console also displays all the errors in the console screen with the line number.
| const { id, name, value } = e.target; | ||
| const s = [...speaker]; | ||
| s[parseInt(id, 10)][name] = value; | ||
| s[parseInt(id)][name] = value; |
There was a problem hiding this comment.
missing radix parameter take reference here
There was a problem hiding this comment.
This all errors are not from my code someone has added these functions i don't know who is but that person has not resolved all this and i have to face this all issue,
| Box, | ||
| Button, | ||
| Grid, | ||
| makeStyles |
There was a problem hiding this comment.
use 2 spaces indentation and Trailing spaces are not allowed according to formator
|
@Amishakumari544 Just add the things that are necessary for your PR, that is related to adding validators on textFields and no more changes. Please work on the latest branch. To work on the latest changes do : |
|
Ok |
|
@Amishakumari544 Any updates? |
3 participants
No description provided.