Skip to content

chore(event-reporter): fixed unit tests lint issues #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reggie-k merged 1 commit into from
Dec 17, 2024
Merged

chore(event-reporter): fixed unit tests lint issues #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions event_reporter/reporter/app_revision_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ func TestGetRevisionsDetails(t *testing.T) {
appServiceClient,
&metrics.MetricsServer{},
fakeArgoDb(),
"0.0.1",
}

result, _ := reporter.getRevisionsDetails(context.Background(), &app, []string{expectedRevision})
Expand Down Expand Up @@ -120,6 +121,7 @@ func TestGetRevisionsDetails(t *testing.T) {
appServiceClient,
&metrics.MetricsServer{},
fakeArgoDb(),
"0.0.1",
}

result, _ := reporter.getRevisionsDetails(context.Background(), &app, []string{expectedRevision1, expectedRevision2})
Expand Down Expand Up @@ -162,6 +164,7 @@ func TestGetRevisionsDetails(t *testing.T) {
appServiceClient,
&metrics.MetricsServer{},
fakeArgoDb(),
"0.0.1",
}

result, _ := reporter.getRevisionsDetails(context.Background(), &app, []string{expectedRevision})
Expand Down
1 change: 1 addition & 0 deletions event_reporter/reporter/application_event_reporter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ func fakeReporter(customAppServiceClient appclient.ApplicationClient) *applicati
customAppServiceClient,
metricsServ,
fakeArgoDb(),
"0.0.1",
}
}

Expand Down
6 changes: 3 additions & 3 deletions event_reporter/reporter/event_payload_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func TestGetResourceEventPayload(t *testing.T) {
app: &app,
appTree: &appTree,
revisionsMetadata: &revisionMetadata,
}, getMockedArgoTrackingMetadata())
}, getMockedArgoTrackingMetadata(), "0.0.1")
require.NoError(t, err)

var eventPayload events.EventPayload
Expand Down Expand Up @@ -110,7 +110,7 @@ func TestGetResourceEventPayload(t *testing.T) {
app: &app,
appTree: &appTree,
revisionsMetadata: &revisionMetadata,
}, getMockedArgoTrackingMetadata())
}, getMockedArgoTrackingMetadata(), "0.0.1")
require.NoError(t, err)

var eventPayload events.EventPayload
Expand Down Expand Up @@ -146,6 +146,6 @@ func TestGetResourceEventPayloadWithoutRevision(t *testing.T) {
}, &ReportedEntityParentApp{
app: &app,
appTree: &appTree,
}, getMockedArgoTrackingMetadata())
}, getMockedArgoTrackingMetadata(), "0.0.1")
assert.NoError(t, err)
}
Loading