Skip to content

Conversation

@dudinea
Copy link
Member

@dudinea dudinea commented Sep 28, 2025

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Eugene Doudine <eugene.doudine@octopus.com>
@codecov
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

❌ Patch coverage is 62.50000% with 33 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
acr_controller/service/acr_service.go 67.90% 19 Missing and 7 partials ⚠️
acr_controller/controller/controller.go 0.00% 3 Missing ⚠️
...commands/application_change_revision_controller.go 0.00% 3 Missing ⚠️
acr_controller/server.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Improved to check annotations, annotations feature flag
and handle more error/no-op conditions

Signed-off-by: Eugene Doudine <eugene.doudine@octopus.com>
@dudinea dudinea marked this pull request as ready for review September 29, 2025 06:02
@reggie-k reggie-k merged commit 51be43f into sync-3.1.5 Sep 29, 2025
36 of 38 checks passed
@reggie-k reggie-k deleted the feat-backport-annotations-support-to-acr branch September 29, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants