Skip to content

Ed/return branch name with pr changes #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kopekC merged 2 commits into from
Mar 20, 2025
Merged

Ed/return branch name with pr changes #924

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89abbf6
feat: return head branch name with pr changes
kopekC Mar 20, 2025
1712612
.
kopekC Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/codegen/sdk/core/codebase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,8 @@
TExport = TypeVar("TExport", bound="Export", default=Export)
TSGlobalVar = TypeVar("TSGlobalVar", bound="Assignment", default=Assignment)
PyGlobalVar = TypeVar("PyGlobalVar", bound="Assignment", default=Assignment)
TSDirectory = Directory[TSFile, TSSymbol, TSImportStatement, TSGlobalVar, TSClass, TSFunction, TSImport]

Check failure on line 112 in src/codegen/sdk/core/codebase.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Cannot resolve name "TSDirectory" (possible cyclic definition)  [misc]
PyDirectory = Directory[PyFile, PySymbol, PyImportStatement, PyGlobalVar, PyClass, PyFunction, PyImport]

Check failure on line 113 in src/codegen/sdk/core/codebase.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Cannot resolve name "PyDirectory" (possible cyclic definition)  [misc]


@apidoc
Expand Down Expand Up @@ -204,18 +204,18 @@
)
projects = [main_project]
else:
main_project = projects[0]

Check failure on line 207 in src/codegen/sdk/core/codebase.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Value of type "list[ProjectConfig] | None" is not indexable  [index]

# Initialize codebase
self._op = main_project.repo_operator
self.viz = VisualizationManager(op=self._op)
self.repo_path = Path(self._op.repo_path)
self.ctx = CodebaseContext(projects, config=config, secrets=secrets, io=io, progress=progress)

Check failure on line 213 in src/codegen/sdk/core/codebase.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Argument 1 to "CodebaseContext" has incompatible type "list[ProjectConfig] | None"; expected "list[ProjectConfig]"  [arg-type]
self.console = Console(record=True, soft_wrap=True)
if self.ctx.config.use_pink != PinkMode.OFF:
import codegen_sdk_pink

self._pink_codebase = codegen_sdk_pink.Codebase(self.repo_path)

Check failure on line 218 in src/codegen/sdk/core/codebase.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Module has no attribute "Codebase"  [attr-defined]

@noapidoc
def __str__(self) -> str:
Expand All @@ -230,7 +230,7 @@
yield "nodes", len(self.ctx.nodes)
yield "edges", len(self.ctx.edges)

__rich_repr__.angular = ANGULAR_STYLE

Check failure on line 233 in src/codegen/sdk/core/codebase.py

View workflow job for this annotation

GitHub Actions / mypy 

error: "Callable[[Codebase[TSourceFile, TDirectory, TSymbol, TClass, TFunction, TImport, TGlobalVar, TInterface, TTypeAlias, TParameter, TCodeBlock]], Iterable[Any | tuple[Any] | tuple[str, Any] | tuple[str, Any, Any]]]" has no attribute "angular"  [attr-defined]

@property
@deprecated("Please do not use the local repo operator directly")
Expand Down Expand Up @@ -272,8 +272,8 @@

@noapidoc
def _symbols(self, symbol_type: SymbolType | None = None) -> list[TSymbol | TClass | TFunction | TGlobalVar]:
matches: list[Symbol] = self.ctx.get_nodes(NodeType.SYMBOL)

Check failure on line 275 in src/codegen/sdk/core/codebase.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Incompatible types in assignment (expression has type "list[Importable[Any]]", variable has type "list[Symbol[Any, Any]]")  [assignment]
return [x for x in matches if x.is_top_level and (symbol_type is None or x.symbol_type == symbol_type)]

Check failure on line 276 in src/codegen/sdk/core/codebase.py

View workflow job for this annotation

GitHub Actions / mypy 

error: List comprehension has incompatible type List[Symbol[Any, Any]]; expected List[TSymbol | TClass | TFunction | TGlobalVar]  [misc]

# =====[ Node Types ]=====
@overload
Expand All @@ -282,7 +282,7 @@
def files(self, *, extensions: Literal["*"]) -> list[File]: ...
@overload
def files(self, *, extensions: None = ...) -> list[TSourceFile]: ...
@proxy_property

Check failure on line 285 in src/codegen/sdk/core/codebase.py

View workflow job for this annotation

GitHub Actions / mypy 

error: "cached_property[ProxyProperty[[Codebase[TSourceFile, TDirectory, TSymbol, TClass, TFunction, TImport, TGlobalVar, TInterface, TTypeAlias, TParameter, TCodeBlock], DefaultNamedArg(list[str] | Literal['*'] | None, 'extensions')], list[TSourceFile] | list[File]]]" not callable  [operator]
def files(self, *, extensions: list[str] | Literal["*"] | None = None) -> list[TSourceFile] | list[File]:
"""A list property that returns all files in the codebase.

Expand Down Expand Up @@ -322,7 +322,7 @@
return sort_editables(files, alphabetical=True, dedupe=False)

@cached_property
def codeowners(self) -> list["CodeOwner[TSourceFile]"]:

Check failure on line 325 in src/codegen/sdk/core/codebase.py

View workflow job for this annotation

GitHub Actions / mypy 

error: "CodeOwner" expects 7 type arguments, but 1 given  [type-arg]
"""List all CodeOnwers in the codebase.

Returns:
Expand Down Expand Up @@ -1527,13 +1527,13 @@
logger.info("Codebase initialization complete")
return codebase

def get_modified_symbols_in_pr(self, pr_id: int) -> tuple[str, dict[str, str], list[str]]:
def get_modified_symbols_in_pr(self, pr_id: int) -> tuple[str, dict[str, str], list[str], str]:
"""Get all modified symbols in a pull request"""
pr = self._op.get_pull_request(pr_id)
cg_pr = CodegenPR(self._op, self, pr)
patch = cg_pr.get_pr_diff()
commit_sha = cg_pr.get_file_commit_shas()
return patch, commit_sha, cg_pr.modified_symbols
return patch, commit_sha, cg_pr.modified_symbols, pr.head.ref

def create_pr_comment(self, pr_number: int, body: str) -> None:
"""Create a comment on a pull request"""
Expand Down