refactor: Apply code quality level 31 for rector

[samsonasik]

Description

Applied ThrowWithPreviousExceptionRector so when throwing into a catch block, checks that the previous exception is passed to the new throw clause

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[samsonasik]

Ready to merge 👍

[paulbalandan]

What is the issue with compact() that this change brings?

[samsonasik]

That's easier to verify that the variable exists and used after defined.

[neznaika0]

I purposely used compact() to compress the string...

[paulbalandan]

It seems both approach emits a warning when the variable is undefined. Difference only is that compact does not give the array key of the undefined variable while the array approach includes the key but with null value instead: https://3v4l.org/pHACp#v8.4.1

I'm not sure which way we want to go, but personally I use compact for its conciseness.

[samsonasik]

Ok, let see what other opinion for it

[michalsn]

Personally, I have nothing against using compact(). It is easy to understand when reviewing the code.

[samsonasik]

Ok, I will skip it. We can continue increase level with skip this rule.

[samsonasik]

I skipped CompactToVariablesRector 37e6329 , then apply level 31 that apply change with ThrowWithPreviousExceptionRector 608b869

[samsonasik]

Ready to merge 👍

[neznaika0]

Go next level)

[samsonasik]

Thanks all for the review, let's merge 👍