fix: exceptions for non-HTML responses#9308
Closed
michalsn wants to merge 3 commits intocodeigniter4:developfrom
Closed
fix: exceptions for non-HTML responses#9308michalsn wants to merge 3 commits intocodeigniter4:developfrom
michalsn wants to merge 3 commits intocodeigniter4:developfrom
Conversation
Member
|
Is there any possibility of unexpected errors being displayed? |
Member
Author
I don't believe so. The |
kenjis
reviewed
Dec 9, 2024
Member
|
@michalsn |
paulbalandan
approved these changes
Dec 9, 2024
Contributor
|
Heh, already there in the next branch |
Member
Author
|
LOL... thanks |
Contributor
|
@michalsn no no, It is worth updating the changelog. This fix is not specified in 4.6 |
5 tasks
Member
Author
|
@neznaika0 I sent a separate PR. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where exceptions for non-HTML responses did not rely on the
display_errorssetting.Fixes: #9242
Checklist: