refactor: enable code quality level 34 for rector#9311
Merged
paulbalandan merged 7 commits intocodeigniter4:4.6from Dec 21, 2024
Merged
Conversation
Member
Author
|
Ready for review 👍 , while doesn't change native type, this can goes to 4.6 branch if needed since it change docblock returns from allowed union void to nullable union and may cause phpstan notice on user that override it. |
Contributor
|
In |
Member
Author
|
On child classes, more specific returns is ok, the parent interface allow |
Member
|
Why are we now returning |
dcf235e to
6538738
Compare
Contributor
Response return in system/CodeIgniter.php and other places: $possibleResponse = $this->runRequiredBeforeFilters($filters); |
michalsn
approved these changes
Dec 11, 2024
paulbalandan
approved these changes
Dec 11, 2024
00b3b1b to
88862ad
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Applied
ExplicitReturnNullRectorto add explicit return null to method/function that returns a value, but missed main return.void in union should not happen.
Checklist: