refactor: enable instanceof and strictBooleans rector set

[samsonasik]

Description

• flip negated instanceof
• apply strict bool check

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[samsonasik]

Ready to merge 👍

[samsonasik]

@paulbalandan review incorporated 👍 ,

for strpos() vs str_contains(), since it check with negation ! strpos(), which include 0 value, means 0 is found at position 0, it not changed to str_contains() to keep behaviour.

except it exactly compare to false will only changed to str_contains() to ensure it safe.

[michalsn]

Hmm... wouldn't the str_contains() be more accurate? I know it changes the behavior a bit, but probably when the code was written no alternative for strpos() was available because of the minimal PHP version.

In this case, we're just checking if collate is already present in the $sql and, if not, adding it. Using strpos() with in_array() seems like complicating the code unnecessarily 🤔

[neznaika0]

Aah, take a look first #9302
I've already fixed most of the cases.

[samsonasik]

@neznaika0 your PR can be merged first if approved :)

[paulbalandan]

looking at the strpos scenarios i think @michalsn is right. before the code is just checking for the existence of the substring, so it doesn't matter if it is found at the beginning.

for the non-falsy string checks, i think those were originally meant for non-empty-string checks?

[samsonasik]

All incorporated 👍

[michalsn]

Thank you, looks good!

[samsonasik]

Feel free to merge PR #9302 from @neznaika0 first, I can rebase later ;)

[paulbalandan]

@samsonasik this can now be rebased

[samsonasik]

@paulbalandan rebased 👍

[michalsn]

👍

[paulbalandan]

Thank you, @samsonasik