refactor: Fix phpstan return.type#9375
Merged
paulbalandan merged 2 commits intocodeigniter4:developfrom Jan 8, 2025
Merged
Conversation
paulbalandan
reviewed
Jan 5, 2025
Member
paulbalandan
left a comment
There was a problem hiding this comment.
This breaks return covariance: https://3v4l.org/J04NA
samsonasik
reviewed
Jan 5, 2025
Contributor
Author
|
|
Member
|
it bc break if |
0bc632c to
8f6a8c0
Compare
Contributor
Author
|
An alternative way to specify the types |
paulbalandan
reviewed
Jan 8, 2025
paulbalandan
approved these changes
Jan 8, 2025
samsonasik
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
staticorselfwill decide what is returned.Checklist: