refactor: Fix phpstan return.missing#9382
Merged
paulbalandan merged 1 commit intocodeigniter4:developfrom Jan 8, 2025
Merged
Conversation
paulbalandan
approved these changes
Jan 8, 2025
Member
paulbalandan
left a comment
paulbalandan
left a comment
There was a problem hiding this comment.
This can go to develop branch.
neznaika0
force-pushed
the
refactor/phpstan-return-missing
branch
from
2d4d866 to
361afa3
Compare
neznaika0
force-pushed
the
refactor/phpstan-return-missing
branch
from
361afa3 to
23da624
Compare
samsonasik
approved these changes
Jan 8, 2025
Contributor
Author
|
Here potential conflict. ../../system/Images/Handlers/BaseHandler.php changed in 4.6 but I could start changing this in develop 😞 |
Member
If the conflict is huge or would lead to different errors in phpstan, then I think we can fix in 4.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Don't you think
MockResultis a dead class? It is not used anywhere.Checklist: