refactor: Fix phpstan method.impossibleType#9384
Merged
paulbalandan merged 3 commits intocodeigniter4:developfrom Jan 10, 2025
Merged
refactor: Fix phpstan method.impossibleType#9384paulbalandan merged 3 commits intocodeigniter4:developfrom
paulbalandan merged 3 commits intocodeigniter4:developfrom
Conversation
7ceb6fd to
68d8f1d
Compare
68d8f1d to
b44901c
Compare
Contributor
Author
|
It's not that easy to rebase branches |
Member
|
You can refer to here if you are switching the base branch. The |
Contributor
Author
|
Thanks, I'll try. Before that, I used cherry-pick and reset --hard |
Member
|
@neznaika0 I wrote a blog post about rebase as well FYI https://samsonasik.wordpress.com/2015/09/16/practical-git-4-rebasing-conflicted-task-branch-against-primary-branch/ |
paulbalandan
approved these changes
Jan 10, 2025
michalsn
approved these changes
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have updated the tests so that they change the object. It's so easy to track event triggers instead of
boolchecks.Fixed the message at the same time:
Call to an undefined method Events::unInitialize()Checklist: