refactor: Fix phpstan method.unused#9388
Merged
paulbalandan merged 1 commit intocodeigniter4:developfrom Jan 10, 2025
Merged
Conversation
paulbalandan
reviewed
Jan 9, 2025
Member
paulbalandan
left a comment
paulbalandan
left a comment
There was a problem hiding this comment.
Where is this fixture being used?
Contributor
Author
paulbalandan
approved these changes
Jan 9, 2025
Member
paulbalandan
left a comment
paulbalandan
left a comment
There was a problem hiding this comment.
Thanks! I think the proper fix for this would be to implement an always used method extension in phpstan-codeigniter. For now, I think this is good.
michalsn
approved these changes
Jan 10, 2025
samsonasik
approved these changes
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Just ignore line. Or should I leave similar errors in the .neon files?
Checklist: