refactor: Fix phpstan codeigniter.configArgumentInstanceof#9390
Merged
paulbalandan merged 1 commit intocodeigniter4:developfrom Jan 13, 2025
Merged
Conversation
paulbalandan
reviewed
Jan 9, 2025
paulbalandan
approved these changes
Jan 10, 2025
Member
|
Shouldn't we allow |
Contributor
Author
|
|
Member
|
Yes, I know, but we're not talking about caching or registrars. This is a question, should the |
michalsn
approved these changes
Jan 11, 2025
Member
michalsn
left a comment
There was a problem hiding this comment.
Seem like no one else is sharing my concern, so let's go.
Contributor
Author
|
Perhaps this is a problem for modular sites, who used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modulesdoes not extendBaseConfig. The object must be created directly bynew Modules()$modules instanceof Modulesit is necessary, otherwise rector tries to overwrite__constructor(). For comparison withnull, there are also rules - a change is acceptable hereChecklist: