fix: Inconsistent directives value between Default and OPCache groups#9476
Merged
paulbalandan merged 3 commits intocodeigniter4:developfrom Mar 19, 2025
Merged
fix: Inconsistent directives value between Default and OPCache groups#9476paulbalandan merged 3 commits intocodeigniter4:developfrom
paulbalandan merged 3 commits intocodeigniter4:developfrom
Conversation
Member
|
I agree to the recommended value, but why suggesting to enable on CLI? From ChatGPT: https://chatgpt.com/share/67d9b778-26d4-800f-9a81-f1cdaf6f7581 |
Contributor
Author
|
This choice actually depends on the user's needs. As GPT mentioned, If you often run queues with cron jobs like send broadcast emails, database migration and seeding, or repetitive CLI scripts, enabling OPcache can be a good choice because it reduces parsing and compilation overhead. But if there is no intense activity in CLI mode, it is better to leave it disabled to save resources. I think we need to improve the message to make it easier to understand, E.g. |
Member
|
Yes, I think we need to put that instead. |
Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>
paulbalandan
approved these changes
Mar 19, 2025
michalsn
approved these changes
Mar 19, 2025
ddevsr
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Explain what you have changed, and why.
Checklist: