fix: Time tests for arab locale#9481
Merged
paulbalandan merged 1 commit intocodeigniter4:developfrom Mar 11, 2025
Merged
Conversation
michalsn
requested changes
Mar 9, 2025
Member
michalsn
left a comment
michalsn
left a comment
There was a problem hiding this comment.
Please use ar-SA, which is the proper convention for intl: https://www.php.net/manual/en/class.locale.php
Contributor
Author
|
See other tests - locales with underscore |
Member
|
In that case, they should also be corrected - but you don't have to do that. Just fix your part. |
neznaika0
force-pushed
the
fix/time-tests-for-arab
branch
from
216a60f to
5bdb6b9
Compare
paulbalandan
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9478
Checklist: