refactor: relax objects allowed in model()

[paulbalandan]

Description
I remember I have read somewhere in the codebase or in the documentation that model() can accept any object other than those extending CodeIgniter\Model as long as that class follow the semantics of the Model class. So, this relaxes the requirement for model() to accept only Model classes.

Supersedes and closes #9391 .

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[neznaika0]

I looked at Factories - the model object is expected. Are you saying that you can return any object?

[paulbalandan]

Yes, look at the PHPDoc of Fabricator::$model:

CodeIgniter4/system/Test/Fabricator.php

Lines 51 to 56 in 0611c35

	/**
	* Model instance (can be non-framework if it follows framework design)
	*
	* @var Model|object
	*/
	protected $model;

Looking at its constructor, it doesn't check for Model explicitly. Just plain object is fine.

CodeIgniter4/system/Test/Fabricator.php

Lines 122 to 131 in 0611c35

	if (is_string($model)) {
	// Create a new model instance
	$model = model($model, false);
	}
	if (! is_object($model)) {
	throw new InvalidArgumentException(lang('Fabricator.invalidModel'));
	}
	$this->model = $model;

Lastly, look at the return type of model():

CodeIgniter4/system/Common.php

Line 800 in 0611c35

* @phpstan-return ($name is class-string<ModelTemplate> ? ModelTemplate : object|null)

[michalsn]

PHPStan errors are unrelated?