fix: Toolbar when maxHistory is set to 0#9506
Merged
michalsn merged 2 commits intocodeigniter4:developfrom Apr 10, 2025
Merged
Conversation
neznaika0
reviewed
Apr 5, 2025
neznaika0
reviewed
Apr 5, 2025
Contributor
neznaika0
left a comment
There was a problem hiding this comment.
All good, but HTMX creates an unlimited number of json files until a new HTTP request is executed (example F5 in browser).
Member
Author
|
IMO, this is fine as-is. The limit should only apply to "normal" requests (when we actually display the toolbar). Otherwise, we’d introduce a much bigger problem: removing a debug entry from history would be possible even though it’s still visible in the list of available data. Let’s avoid complicating things unnecessarily. If you're using the codeigniter-htmx library, you should not experience this problem since the debug toolbar is reloaded on every request. |
0de8a00 to
353c0e3
Compare
neznaika0
approved these changes
Apr 8, 2025
paulbalandan
approved these changes
Apr 9, 2025
Member
Author
|
Thank you @paulbalandan and @neznaika0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issues with the debug bar when
maxHistoryis set to0:Fixes #9504
Checklist: