refactor: fix missingType.return errors#9523
Merged
samsonasik merged 3 commits intocodeigniter4:developfrom Apr 14, 2025
Merged
refactor: fix missingType.return errors#9523samsonasik merged 3 commits intocodeigniter4:developfrom
missingType.return errors#9523samsonasik merged 3 commits intocodeigniter4:developfrom
Conversation
samsonasik
reviewed
Apr 13, 2025
efd2cee to
60b69cd
Compare
paulbalandan
approved these changes
Apr 14, 2025
|
👋 Hi, @warcooft! |
missingType.return errors
Member
|
Thanks, @warcooft, for helping in clearing the phpstan errors! Can you please rebase and regenerate the baseline? |
michalsn
approved these changes
Apr 14, 2025
ddevsr
approved these changes
Apr 14, 2025
Member
|
You need to use rebase instead of merge |
ed57498 to
f57b12a
Compare
Contributor
Author
|
@samsonasik Just checking, did the rebase finish correctly? |
samsonasik
approved these changes
Apr 14, 2025
Member
|
Thank you @warcooft |
Contributor
Author
|
Thanks for the quick guidance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes
missingType.returnerrors.Checklist: