feat: I18n\Time::addCalendarMonth#9527
Closed
christianberkman wants to merge 9 commits intocodeigniter4:developfrom
christianberkman:4.7-addCalendarMonth
Closed
feat: I18n\Time::addCalendarMonth#9527christianberkman wants to merge 9 commits intocodeigniter4:developfrom christianberkman:4.7-addCalendarMonth
christianberkman wants to merge 9 commits intocodeigniter4:developfrom
christianberkman:4.7-addCalendarMonth
Conversation
* -revert: auto corrected (composer cs-fix) comments and auto added function return types -comment: add depreceation comment for failedSMTPLogin email error message -refactor: improve authorization validation flow and email error response messages -added $SMTPAuthMethod in Config\Email file with default value of login * Update system/Email/Email.php apply suggestion for declaring string type of $SMTPAuthMethod Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com> * Update user_guide_src/source/libraries/email.rst Apply Suggestion for description of SMTPAuthMethod Co-authored-by: Michal Sniatala <michal@sniatala.pl> * docs: update changelog * fix: php-cs violations * Update user_guide_src/source/changelogs/v4.7.0.rst Apply suggestions for changelog Co-authored-by: Michal Sniatala <michal@sniatala.pl> --------- Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com> Co-authored-by: Michal Sniatala <michal@sniatala.pl>
Contributor
Author
|
Wrong branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Time::addMonths()could return an undesired behaviour if a date in the next calandar month is desired. For example,Time(2025-01-31)->addMonths(1)results in2025-03-03while a date in february may be desired, orTime(2025-03-31)->addMonths(1)results in a date in May not in April. Of course, this only applies if the dev is looking for a date in the next calendar month (months are weird of course, it is 30, 31, 28, 29 days...? who knows).Comparison
Checklist:
If deemed worthy to include I will write test and documentation.