test: fix codeigniter.unknownServiceMethod errors#9532
Merged
paulbalandan merged 1 commit intocodeigniter4:developfrom Apr 19, 2025
Merged
test: fix codeigniter.unknownServiceMethod errors#9532paulbalandan merged 1 commit intocodeigniter4:developfrom
codeigniter.unknownServiceMethod errors#9532paulbalandan merged 1 commit intocodeigniter4:developfrom
Conversation
michalsn
approved these changes
Apr 18, 2025
Member
michalsn
left a comment
There was a problem hiding this comment.
I'm not sure I understand the benefit of moving these from the baseline file into inline comments.
I get that the baseline is typically used for issues we plan to fix eventually - but filling the source code with a lot of phpstan suppression comments doesn't feel ideal either.
I have mixed feelings about it, but it seems like the right choice for now.
Member
Author
|
The way I see it:
|
bcaeeea to
c0bbac4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These errors are not phpstan false reports. These are intended for testing purposes thus we can safely locally ignore them.
Checklist: