refactor: fix codeigniter.modelArgumentType errors#9533
Merged
paulbalandan merged 1 commit intocodeigniter4:developfrom Apr 20, 2025
Merged
refactor: fix codeigniter.modelArgumentType errors#9533paulbalandan merged 1 commit intocodeigniter4:developfrom
codeigniter.modelArgumentType errors#9533paulbalandan merged 1 commit intocodeigniter4:developfrom
Conversation
02408bf to
65698b8
Compare
Member
Author
|
It seems the approach of requiring shield brings a lot of testing errors. Skipping that solution for now. |
65698b8 to
9452a30
Compare
michalsn
approved these changes
Apr 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tests\Support\Modelsnamespace as known model namespaces.3. Adding Shield's namespace is not enough since PHPStan must know the class do exist, so we required shield as a dev dependency.Checklist: