refactor: fix Session and SessionInterface code#9535
Merged
paulbalandan merged 1 commit intocodeigniter4:developfrom Apr 21, 2025
Merged
refactor: fix Session and SessionInterface code#9535paulbalandan merged 1 commit intocodeigniter4:developfrom
Session and SessionInterface code#9535paulbalandan merged 1 commit intocodeigniter4:developfrom
Conversation
michalsn
previously approved these changes
Apr 20, 2025
michalsn
reviewed
Apr 20, 2025
I noticed some potential problems in the markAsFlashdata() method.
afc2ca8 to
f9c81a5
Compare
5 tasks
michalsn
approved these changes
Apr 21, 2025
f9c81a5 to
fab7a8c
Compare
Member
Author
|
Rebased to show the added tests pass on this refactor. |
fab7a8c to
06ad241
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While looking at #9534 to find where the culprit is (in
markAsTempData()), I found some points for improvements for the Session class:array|bool|float|int|object|string|nullis just the long form ofmixed. If the type cannot be narrowed further (likestring|int|null), I see no benefit in writing the long form instead of justmixed.Checklist: