fix: added "application/octet-stream" to the "stl" mime type in the Mimes config class#9541
fix: added "application/octet-stream" to the "stl" mime type in the Mimes config class#9541Franky5831 wants to merge 0 commit intocodeigniter4:developfrom
Conversation
|
Hi there, Franky5831! 👋 Thank you for sending this PR! We expect the following in all Pull Requests (PRs).
Important We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works. If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md Sincerely, the mergeable bot 🤖 |
|
Hey, I noticed the commit was unverified, I just added my GPG key and my commits are now verified, what should I do? Should I close it and do it over again? |
|
you can do push --force, better to create different branch first tho so you can have easy on sync on future PR, see https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#how-to-guide |
Description
I added the "application/octet-stream" to the "stl" mime type in the Mimes config class because when I upload a stl file the mime type returns as "application/octet-stream" and the
ext_ininput validation returns false.I opened this issue and have been told to create a pull request.
Checklist: