fix: throw exception for unsupported DB drivers in session#9574
Merged
michalsn merged 1 commit intocodeigniter4:developfrom May 26, 2025
Merged
fix: throw exception for unsupported DB drivers in session#9574michalsn merged 1 commit intocodeigniter4:developfrom
michalsn merged 1 commit intocodeigniter4:developfrom
Conversation
paulbalandan
approved these changes
May 24, 2025
Member
Author
|
Thank you @paulbalandan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
sessionservice logic by adding a check for unsupported database platforms. If a developer attempts to useDatabaseHandlerwith an unsupported driver (e.g., SQLSRV, OCI8, SQLite3), anInvalidArgumentExceptionwill now be thrown with a clear error message.Problem spotted here: #9572
Checklist: