fix: correct getHostname() fallback logic in Email class#9587
Merged
michalsn merged 1 commit intocodeigniter4:developfrom May 31, 2025
Merged
fix: correct getHostname() fallback logic in Email class#9587michalsn merged 1 commit intocodeigniter4:developfrom
getHostname() fallback logic in Email class#9587michalsn merged 1 commit intocodeigniter4:developfrom
Conversation
michalsn
added
the
bug
paulbalandan
approved these changes
May 30, 2025
|
👋 Hi, @michalsn! |
datamweb
approved these changes
May 31, 2025
Contributor
datamweb
left a comment
datamweb
left a comment
There was a problem hiding this comment.
The PR looks good and the test is clear and logical. Just needs a rebase before merge.
michalsn
force-pushed
the
fix/get-hostname
branch
from
56f3032 to
49ee67c
Compare
Member
Author
|
Thank you @paulbalandan and @datamweb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
getHostname()method in theEmailclass to ensure it correctly falls back to the server address or system hostname in order of availability. In some environments, such as Google App Engine,$_SERVER['SERVER_NAME']may be set but empty.Problem reported here: #9448 (comment)
Checklist: