fix: DatabaseLive tests failing locally#9669
fix: DatabaseLive tests failing locally#9669paulbalandan merged 4 commits intocodeigniter4:developfrom
DatabaseLive tests failing locally#9669Conversation
c865ba8 to
36aff17
Compare
36aff17 to
ad1f42c
Compare
|
This fix, although passing, is not yet deterministic, as this assumes there's no |
cf27321 to
87fd50d
Compare
|
If I understood databases better (and I don't have some on unix), I would try to change the tests. Make them unique, without dependencies. PHPUnit has a randomization option, which is ideal for applying it to the entire project. |
|
Randomising the tests has been envisioned before but early attempts proved very difficult to implement as there are hidden interdependencies within the tests, especially the database tests. That's why up until now we don't have random testing and mutation testing cannot be setup also. |
|
This fix is okay for the meantime as we are not using randomised testing. Once we randomise the tests, we need to isolate and eliminate dependencies. |
neznaika0
left a comment
There was a problem hiding this comment.
My local tests passed. Thanks!
|
I'm glad you figured it out. Thanks @paulbalandan |
|
Thanks for the reviews! |
Description
Fixes #9668
Checklist: