fix: Forge::modifyColumn() for Postgre handler#9676
Merged
michalsn merged 2 commits intocodeigniter4:developfrom Aug 15, 2025
Merged
fix: Forge::modifyColumn() for Postgre handler#9676michalsn merged 2 commits intocodeigniter4:developfrom
Forge::modifyColumn() for Postgre handler#9676michalsn merged 2 commits intocodeigniter4:developfrom
Conversation
michalsn
added
the
bug
Member
Author
|
@paulbalandan, given the recent testing challenges, do you have any thoughts on why this only happens with OCI8 and SQLSRV? Interestingly, migration locks (#9660) follow the same approach of creating a table for just one test case, but they don't seem to have these issues... |
Member
|
The test fails so the cleanup isn't reached causing |
Member
Author
|
Idk what I was thinking... I totally missed the errors... sorry 🤦 |
michalsn
added
the
database
michalsn
force-pushed
the
fix/modifyColumn-postgre
branch
from
14c5562 to
4721884
Compare
neznaika0
reviewed
Aug 14, 2025
Contributor
neznaika0
left a comment
neznaika0
left a comment
There was a problem hiding this comment.
I'm reviewing all the PR, but I don't know much for approval. It looks good.
paulbalandan
approved these changes
Aug 15, 2025
Member
Author
|
Thank you @paulbalandan and @neznaika0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in
Postgrewhere changing a column's default value viaConfig\Database\Forge::modifyColumn()would result in incorrect SQL syntax.Fixes #9671
Checklist: