fix: controller attribute filters with parameters#9769
Merged
michalsn merged 2 commits intocodeigniter4:4.7from Oct 23, 2025
Merged
fix: controller attribute filters with parameters#9769michalsn merged 2 commits intocodeigniter4:4.7from
michalsn merged 2 commits intocodeigniter4:4.7from
Conversation
lonnieezell
approved these changes
Oct 23, 2025
Member
lonnieezell
left a comment
There was a problem hiding this comment.
My bad for the bad example in the docs. That was definitely an oops on my part.
But this solution seems good. I don't see any issues, and allows a little more flexibility on the user end.
datamweb
reviewed
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with controller attribute filters that use parameters. See: #9745 (comment)
Filter parameters are always declared as strings elsewhere in the framework, and there is no supported way to handle them differently. See:
To maintain consistency, this change ensures that filter parameters are treated as strings, matching the existing convention. Any other behavior would introduce inconsistency.
All existing tests have been kept, even those that may not make much sense in this context, to serve as examples of how filters handle mixed-type parameters (they are converted to strings).
This change only affects Filters - everything else will continue to behave as before.
Checklist: