fix: Override merging behaviour#9799
Closed
warcooft wants to merge 4 commits intocodeigniter4:developfrom
Closed
Conversation
Contributor
Contributor
|
We didn't make the right decision. And this is BC, in 4.7 with the update of the docs and tests. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves how configuration values are merged during registrar discovery. Previously, nested configuration arrays (e.g., globals['before']) were being overwritten because the merging process used array_merge(), which only works at the top level. As a result, any registrar attempting to append or modify nested config values would unintentionally replace the entire subtree.
This ensures that nested configuration arrays are merged correctly without overwriting existing keys, providing more predictable and safer behavior for external packages and modules that rely on registrars.
Checklist: