docs: remove internal tag from Throttler::check() description#9817
Merged
michalsn merged 1 commit intocodeigniter4:developfrom Dec 1, 2025
Merged
Conversation
datamweb
approved these changes
Nov 30, 2025
neznaika0
approved these changes
Nov 30, 2025
Contributor
neznaika0
left a comment
There was a problem hiding this comment.
CodeIgniter4/system/Throttle/Throttler.php
Lines 79 to 81 in 5927784
This is initially a mistake. There may have been changes, but they forgot to update the comment.
In addition, there is an interface mismatch. The returned type is bool
Member
Author
|
Any changes to the interface have to go to the |
paulbalandan
approved these changes
Nov 30, 2025
Member
Author
|
Thank you for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the @internal tag from the
Throttler::check()method description.It seems like a mistake and can be removed, as it doesn't provide meaningful information and might be confusing.
Fixes #9813
Checklist: