refactor: Types for BaseModel, Model and dependencies#9830
Merged
michalsn merged 3 commits intocodeigniter4:4.7from Dec 13, 2025
Merged
refactor: Types for BaseModel, Model and dependencies#9830michalsn merged 3 commits intocodeigniter4:4.7from
BaseModel, Model and dependencies#9830michalsn merged 3 commits intocodeigniter4:4.7from
Conversation
de4b6e8 to
9b5e64b
Compare
michalsn
approved these changes
Dec 12, 2025
Member
michalsn
left a comment
There was a problem hiding this comment.
I think this looks good to me.
paulbalandan
approved these changes
Dec 12, 2025
5 tasks
Member
|
Thank you @neznaika0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9711
It is better to merge the develop branch for the review.
I have re-examined the proposed ID check method. I realized that it is less useful for BaseModel. The method is useful in the Model. As long as you consider the check to be breaking changes, let everything stay as it was.
There is a note for
row_array- in the case of casting, the value can be mixed. Contain any type inside, which is converted to scalars. Find the error in utils/phpstan-baseline/argument.type.neon DataConverterModelTest.phpChecklist: